Skip to content

fix: allow empty string and zero values to be retrieved from RequestsCookieJar #7008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: allow empty string and zero values to be retrieved from RequestsCookieJar #7008

wants to merge 1 commit into from

Conversation

SamanyuYN
Copy link

Summary

Fixes an issue (#7003) where cookies with an empty string ('') or zero (0) value were treated as missing.

Changes

  • Updated _find_no_duplicates to check is not None instead of truthiness.
  • Added unit test to verify behavior.

Fixes #7003

@nateprewitt
Copy link
Member

It looks like this is a duplicate of #7004. We'll resolve in favor of the original.

@nateprewitt nateprewitt closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using RequestsCookieJar to set a cookie with an empty string ('') or 0 as the value, it cannot be retrieved properly afterward.
2 participants
@SamanyuYN @nateprewitt