add --dm [name] to get concise format for only one partition #86
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new optional partition name parameter to the --dm flag of the toc command, allowing users to get concise device-mapper format output for a single partition instead of all partitions. It also updates GitHub Actions upload-artifact from v3 to v4 and includes code formatting improvements.
- Adds
--dm [name]option to filter device-mapper output by partition name - Updates
actions/upload-artifactfrom v3 to v4 in CI workflow - Applies clang-format code style fixes (indentation corrections)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| hdl_dump.c | Adds partition name filtering to show_dm_toc() function, updates function signatures, adds argument parsing for the new optional partition name parameter, updates help documentation, and applies formatting fixes |
| .github/workflows/compilation.yml | Updates actions/upload-artifact from v3 to v4 for both build jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: tar -zcvf hdl-dump-${{ env.SHA }}-windows-latest.tar.gz rel | ||
|
|
||
| - uses: actions/upload-artifact@v3 | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Same issue as line 32: upgrading actions/upload-artifact to v4 while keeping actions/download-artifact at v3 (line 79) may cause compatibility issues. Consider also upgrading actions/download-artifact to v4.
| const char *device_name, | ||
| const char *option) | ||
| const char *option, | ||
| const char *path_name) |
There was a problem hiding this comment.
The parameter name path_name is misleading. This parameter receives a partition name (e.g., "PP.HDL.Tekken"), not a path. It should be renamed to part_name to match its actual usage in show_dm_toc and improve code clarity.
| run: tar -zcvf hdl-dump-${{ env.SHA }}-${{matrix.os}}.tar.gz hdl_dump | ||
|
|
||
| - uses: actions/upload-artifact@v3 | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Upgrading actions/upload-artifact to v4 while keeping actions/download-artifact at v3 (line 79) may cause compatibility issues. The v4 upload action has breaking changes in how artifacts are structured. Consider also upgrading actions/download-artifact to v4 to ensure compatibility, or keep both at v3 until all can be upgraded together.
There was a problem hiding this comment.
1 participant
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description