Improve STEP file import on Linux #13761
Conversation
The FHS says that libraries should be installed in the library directory on Linux.
This implements a saner version check. We only have to link against TKDESTEP. The target has all the needed dependencies set.
| @@ -19,35 +19,23 @@ include(GenerateExportHeader) | |||
|
|
|||
| generate_export_header(OCCTWrapper) | |||
|
|
|||
| find_package(OpenCASCADE 7.6.1 REQUIRED) | |||
| find_package(OpenCASCADE REQUIRED) | |||
There was a problem hiding this comment.
I'm afraid this will conflict with expectations from c6a0210.
Specifically for Fedora I filed https://bugzilla.redhat.com/show_bug.cgi?id=2333653 as the issue does not seem to be fixed in OCCT 2.8.1 which we have there.
There was a problem hiding this comment.
Fedora already has OpenCascade 7.8.1. Looking at https://tracker.dev.opencascade.org/ I'm not able to find a bug report about it.
I wonder if this has been reported upstream.
There was a problem hiding this comment.
The very same question popped into my head, I asked about it in #12122 (comment).
I've now filed https://bugzilla.redhat.com/show_bug.cgi?id=2333659 to possibly do a downstream fix in Fedora, before this gets upstream and Fedora rebases to the latest release. |
Hi,
my name is Andreas Schneider, I'm a FOSS Hacker and new to 3D Printing.
I recognized that opening STEP files in Fedora and OpenSUSE isn't working. I've changed the installation of OCCTWrapper.so so it is installed in the right place on Linux and loaded correctly. I also moved the version check of OC to Prusa as they only do exact checks even for minor version bumps. There is also no need to list all the targets to link, we only need TKDESTEP. The cmake config sets all the required dependent libraries.