Add support for building for Windows on ARM64, natively. #13116

hmartinez82 · 2024-07-18T03:43:05Z

This adds the required changes to build for Windows on ARM on a Windows on ARM machine. No cross compilation supported yet.

Notable changes:

Adds pre-compiled MPFR and GMP binaries
Uses the correct WebView2Loader on ARM64 machines

Fixes #13107 and #12291

hmartinez82 · 2024-07-18T03:47:32Z

@JustinBeckerMSFT ^_^

Cherry-picked from prusa3d/PrusaSlicer@b11b454 Ref: prusa3d/PrusaSlicer#13116

Cherry-picked from prusa3d/PrusaSlicer@b11b454 Ref: prusa3d/PrusaSlicer#13116 Co-authored-by: Hernan Martinez <[email protected]>

eblieb · 2024-07-18T12:47:41Z

Can't you use ARM64X to fix the cross compatibility issue?

hmartinez82 · 2024-07-18T14:53:14Z

Can't you use ARM64X to fix the cross compatibility issue?

It's already working, everything fully native.
No need to use Arm64X 🙂

ggppjj · 2024-07-18T15:14:13Z

I believe they meant "to enable cross-compilation".

hmartinez82 · 2024-07-18T15:23:08Z

I believe they meant "to enable cross-compilation".

Well that's not what ARM64EC/ARM64X are used for. Those are ABI types. It has nothing to do with the ability to build an ARM64, ARM64EC or ARM64X binary from a x64 host machine. (The latter is which I mean by cross-compilation).

JustinBeckerMSFT · 2024-07-18T16:47:50Z

@hmartinez82 Excellent work! What is the minimal command line invocation I need to try building this on my machine?

hmartinez82 · 2024-07-18T17:04:06Z

@JustinBeckerMSFT from a native ARM64 Developer Command Prompt in a ARM64 machine, the build instructions are the same as the manual x64 ones as detailed here: https://github.com/prusa3d/PrusaSlicer/blob/master/doc/How%20to%20build%20-%20Windows.md#2a-manual-build-instructions

SachCZ

Hello @hmartinez82,
thank you very much for your work. It is a very valuable addition which we intend to use to enable building for windows on ARM64. It seems everything you proposed look good!

From our position we have the luxury to update some dependencies (something we want to do anyway) so some of the patches will not be necessary. I added notes about the versions in the review.

Also the state of cmake around mpfr + gmp on windows can be described as "not great". We intend to take arm64 into consideration when addressing it.

The final thing is that we will have to create/source our own gmp and mpfr dlls as we cannot just include any binary in our codebase for security reasons. I am absolutely certain that your intentions are pure, so please do not take it personally.

SachCZ · 2024-09-19T11:32:07Z

deps/+Boost/Boost.patch

+-#if defined(BOOST_JSON_HAS_MSVC_32BIT_INTRINSICS)
+#if defined(BOOST_JSON_HAS_MSVC_32BIT_INTRINSICS) && !defined(_M_ARM64)


This is in boost 1.84.0 so we will rather update boost.

@SachCZ I'm finally back. When do you think this will happen. I can rebase this branch (I'm 280+ commits behind). And I would like to keep the branch in a buildable state.

SachCZ · 2024-09-19T11:34:18Z

deps/+GLEW/GLEW.patch

+   target_compile_definitions (glew PRIVATE "GLEW_BUILD;VC_EXTRALEAN")
+   target_compile_definitions (glew_s PRIVATE "GLEW_STATIC;VC_EXTRALEAN")
+-  target_link_libraries (glew LINK_PRIVATE -BASE:0x62AA0000)
+  if(CMAKE_SYSTEM_PROCESSOR MATCHES "^(i?86|x86|x86_32)$")


For future reference: fix is in glew master but it is not released yet.

SachCZ · 2024-09-19T11:37:35Z

deps/+GMP/GMP.cmake

-    set(_output  ${_dstdir}/include/gmp.h 
-                 ${_dstdir}/lib/libgmp-10.lib 
-                 ${_dstdir}/bin/libgmp-10.dll)
+    set(_output ${_dstdir}/include/gmp.h)
+
+    if (CMAKE_SYSTEM_PROCESSOR MATCHES "^(ARM64|aarch64)$")
+        list(APPEND _output ${_dstdir}/lib/gmp.lib
+                            ${_dstdir}/bin/gmp-10.dll)
+        set(_gmplib winarm64/gmp.lib)
+        set(_gmpdll winarm64/gmp-10.dll)
+    else()
+        list(APPEND _output ${_dstdir}/lib/libgmp-10.lib
+                            ${_dstdir}/bin/libgmp-10.dll)
+        set(_gmplib win${DEPS_BITS}/libgmp-10.lib)
+        set(_gmpdll win${DEPS_BITS}/libgmp-10.dll)
+    endif()                 


In the near future we want to refactor the cmake so it uses an interface target to link against the pre-compiled dlls. We will move these ifs there.

SachCZ · 2024-09-19T11:38:29Z

deps/+OpenEXR/OpenEXR.patch

+-#if defined __SSE2__ || (_MSC_VER >= 1300 && !_M_CEE_PURE)
+#if defined __SSE2__ || (_MSC_VER >= 1300 && !_M_CEE_PURE) && !defined(_M_ARM64)


This is hopefully fixed in OpenEXR 3.2.0.

Apparently so, the file is now way more comprehensive and even has NEON optimizations https://github.com/AcademySoftwareFoundation/openexr/blob/v3.3.0/src/lib/OpenEXR/ImfSimd.h

deps/+wxWidgets/wxWidgets.patch

hmartinez82 · 2024-09-19T12:39:32Z

Understood. I'll remove the binaries and rebase this branch on top of master.
Also feel free to modify the branch directly. I allowed maintainer pushes.

See nigels-com/glew#384

This was referenced Jul 18, 2024

GLEW: Set base address only in 32bit #13108

Closed

OpenEXR: Do no use x86 intrinsics in ARM64 #13109

Closed

Boost: Add necessary changes for Windows on ARM64 #13110

Closed

WIP: Windows on ARM64 #12402

Closed

ElectricalBoy mentioned this pull request Jul 18, 2024

Windows on ARM Build of OrcaSlicer SoftFever/OrcaSlicer#5783

Open

1 task

hmartinez82 mentioned this pull request Jul 18, 2024

[Request] Windows 11 ARM64 build #12291

Open

ElectricalBoy added a commit to ElectricalBoy/Orca-deps-wxWidgets that referenced this pull request Jul 18, 2024

Use ARM64 webview for ARM64 systems

541bed0

Cherry-picked from prusa3d/PrusaSlicer@b11b454 Ref: prusa3d/PrusaSlicer#13116

ElectricalBoy mentioned this pull request Jul 18, 2024

Use ARM64 webview for ARM64 systems SoftFever/Orca-deps-wxWidgets#2

Merged

ElectricalBoy added a commit to ElectricalBoy/Orca-deps-wxWidgets that referenced this pull request Jul 18, 2024

Use ARM64 webview for ARM64 systems

794e8eb

Cherry-picked from prusa3d/PrusaSlicer@b11b454 Ref: prusa3d/PrusaSlicer#13116

ElectricalBoy added a commit to ElectricalBoy/Orca-deps-wxWidgets that referenced this pull request Jul 18, 2024

Use ARM64 webview for ARM64 systems

89322bf

Cherry-picked from prusa3d/PrusaSlicer@b11b454 Ref: prusa3d/PrusaSlicer#13116 Co-authored-by: Hernan Martinez <[email protected]>

ElectricalBoy mentioned this pull request Jul 18, 2024

Windows on ARM Build SoftFever/OrcaSlicer#6173

Closed

SachCZ reviewed Sep 19, 2024

View reviewed changes

hmartinez82 added 9 commits October 16, 2024 18:39

GLEW: Set base address only in 32bit

c9320bd

See nigels-com/glew#384

OpenEXR: Do no use x86 intrinsics in ARM64

60b211d

Boost: Use Windows Fibers as Boost.Context implementation on MSVC/ARM64

b92707e

Add Boost.json patch for ARM64

241acf2

libslic3r: Do not use x86 intrinsics in on ARM64 builds

1756afe

MPFR: Add MSVC pre-compiled ARM64 binaries

b8c38e8

GMP: Add MSVC pre-compiled ARM64 binaries

26714b4

PrusaSlicer: Copy arch specific GMP and MPFR dynamic libraries to output

2adf117

GMP, MPFR: Rename link libraries to match the FindPackage convention

5f176e7

hmartinez82 force-pushed the win_arm64_full branch from b11b454 to 6cfe2dc Compare October 17, 2024 00:51

wxWidgets: Copy ARM64 WebView2Loader binary to output

fda7436

hmartinez82 force-pushed the win_arm64_full branch from 6cfe2dc to fda7436 Compare October 17, 2024 00:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for building for Windows on ARM64, natively. #13116

Add support for building for Windows on ARM64, natively. #13116

hmartinez82 commented Jul 18, 2024 •

edited

Loading

hmartinez82 commented Jul 18, 2024

eblieb commented Jul 18, 2024 •

edited

Loading

hmartinez82 commented Jul 18, 2024

ggppjj commented Jul 18, 2024

hmartinez82 commented Jul 18, 2024 •

edited

Loading

JustinBeckerMSFT commented Jul 18, 2024

hmartinez82 commented Jul 18, 2024 •

edited

Loading

SachCZ left a comment

SachCZ Sep 19, 2024

hmartinez82 Oct 17, 2024 •

edited

Loading

SachCZ Sep 19, 2024

SachCZ Sep 19, 2024

SachCZ Sep 19, 2024

hmartinez82 Oct 17, 2024

hmartinez82 commented Sep 19, 2024 •

edited

Loading

		-#if defined(BOOST_JSON_HAS_MSVC_32BIT_INTRINSICS)
		+#if defined(BOOST_JSON_HAS_MSVC_32BIT_INTRINSICS) && !defined(_M_ARM64)

		-#if defined __SSE2__ \|\| (_MSC_VER >= 1300 && !_M_CEE_PURE)
		+#if defined __SSE2__ \|\| (_MSC_VER >= 1300 && !_M_CEE_PURE) && !defined(_M_ARM64)

Add support for building for Windows on ARM64, natively. #13116

Are you sure you want to change the base?

Add support for building for Windows on ARM64, natively. #13116

Conversation

hmartinez82 commented Jul 18, 2024 • edited Loading

hmartinez82 commented Jul 18, 2024

eblieb commented Jul 18, 2024 • edited Loading

hmartinez82 commented Jul 18, 2024

ggppjj commented Jul 18, 2024

hmartinez82 commented Jul 18, 2024 • edited Loading

JustinBeckerMSFT commented Jul 18, 2024

hmartinez82 commented Jul 18, 2024 • edited Loading

SachCZ left a comment

Choose a reason for hiding this comment

SachCZ Sep 19, 2024

Choose a reason for hiding this comment

hmartinez82 Oct 17, 2024 • edited Loading

Choose a reason for hiding this comment

SachCZ Sep 19, 2024

Choose a reason for hiding this comment

SachCZ Sep 19, 2024

Choose a reason for hiding this comment

SachCZ Sep 19, 2024

Choose a reason for hiding this comment

hmartinez82 Oct 17, 2024

Choose a reason for hiding this comment

hmartinez82 commented Sep 19, 2024 • edited Loading

hmartinez82 commented Jul 18, 2024 •

edited

Loading

eblieb commented Jul 18, 2024 •

edited

Loading

hmartinez82 commented Jul 18, 2024 •

edited

Loading

hmartinez82 commented Jul 18, 2024 •

edited

Loading

hmartinez82 Oct 17, 2024 •

edited

Loading

hmartinez82 commented Sep 19, 2024 •

edited

Loading