Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-7932: add option to repeat last layer while reducing extrusion to get a flush last layer in vase mode closes #11282

Closed
wants to merge 1 commit into from

Conversation

b3n3d1k7
Copy link

closes #7932

@b3n3d1k7 b3n3d1k7 force-pushed the issue-7932 branch 3 times, most recently from 6234271 to 26c01c9 Compare September 19, 2023 17:59
@b3n3d1k7 b3n3d1k7 marked this pull request as ready for review September 19, 2023 18:09
@b3n3d1k7
Copy link
Author

@bubnikv I noticed you implemented the tapering of the extrusion for the first spiral vase layer back in 2020.
Could you maybe take a look at this PR to improve/fix the last spiral vase layer.
It is heavily based on your implementation 😉
I would greatly appreciate your feedback.

I added some screenshots and photos of prints with the fix vs without in comments of the linked issue:

@tg73
Copy link
Contributor

tg73 commented Jan 28, 2024

FYI, equivalent functionality is included in #12142 (my pr) and likely in #12079 (not mine, but based on the same port from OrcaSlicer, I didn't notice this PR before opening mine). With these PRs, the "graceful end" is always performed. These PRs also provide other significant improvements to vase mode.

@b3n3d1k7
Copy link
Author

b3n3d1k7 commented Mar 9, 2024

FYI, equivalent functionality is included in #12142 (my pr) and likely in #12079 (not mine, but based on the same port from OrcaSlicer, I didn't notice this PR before opening mine). With these PRs, the "graceful end" is always performed. These PRs also provide other significant improvements to vase mode.

I will close this PR, as it is pretty much useless now with the two other ones.

@b3n3d1k7 b3n3d1k7 closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful end of vase mode print
3 participants