Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Envoy filter metadata example. #289

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Envoy filter metadata example. #289

wants to merge 7 commits into from

Conversation

Swaagie
Copy link
Contributor

@Swaagie Swaagie commented Nov 4, 2024

fixes #288. Happy to adjust this to where it has the most value/clear use cases.

@Swaagie Swaagie requested a review from PiotrSikora as a code owner November 4, 2024 11:54
@Swaagie Swaagie force-pushed the metadata-example branch 3 times, most recently from 4077239 to 63e7058 Compare November 4, 2024 12:08
examples/filter_metadata/envoy.yaml Outdated Show resolved Hide resolved
examples/filter_metadata/envoy.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Swaagie Swaagie force-pushed the metadata-example branch 2 times, most recently from 24dd22c to 345678d Compare November 28, 2024 09:27
@Swaagie
Copy link
Contributor Author

Swaagie commented Nov 28, 2024

@PiotrSikora suggestions have been implemented

edit: requires #291 (review) to pass checks.

@PiotrSikora
Copy link
Member

Could you add this to the CI as well? Simply add entry to the matrices in the examples and reactors jobs. Thanks!

examples/envoy_filter_metadata/src/lib.rs Outdated Show resolved Hide resolved
examples/envoy_filter_metadata/README.md Outdated Show resolved Hide resolved
examples/envoy_filter_metadata/README.md Outdated Show resolved Hide resolved
@PiotrSikora PiotrSikora changed the title Add metadata example Add Envoy filter metadata example. Dec 2, 2024
@Swaagie Swaagie force-pushed the metadata-example branch 2 times, most recently from af11338 to cdc339a Compare December 2, 2024 09:54
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
@Swaagie Swaagie requested a review from PiotrSikora December 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an example to read metadata set by other filters
3 participants