chore: implement suggestion

proxy-wasm · Nov 28, 2024 · 9185a3d · 9185a3d
1 parent 16f5ca5
commit 9185a3d
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@
 - [HTTP Response body](./examples/http_body/)
 - [HTTP Configuration](./examples/http_config/)
 - [gRPC Auth (random)](./examples/grpc_auth_random/)
-- [Filter metadata](./examples/filter_metadata/)
+- [Envoy filter metadata](./examples/envoy_filter_metadata/)
 
 ## Articles & blog posts from the community
 

diff --git a/examples/filter_metadata/Cargo.toml → examples/envoy_filter_metadata/Cargo.toml b/examples/filter_metadata/Cargo.toml → examples/envoy_filter_metadata/Cargo.toml
@@ -1,9 +1,9 @@
 [package]
 publish = false
-name = "proxy-wasm-example-filter-metadata"
+name = "proxy-wasm-example-envoy-filter-metadata"
 version = "0.0.1"
 authors = ["Martijn Swaagma <[email protected]>"]
-description = "Proxy-Wasm plugin example: Filter metadata"
+description = "Proxy-Wasm plugin example: Envoy filter metadata"
 license = "Apache-2.0"
 edition = "2018"
 

diff --git a/examples/filter_metadata/README.md → examples/envoy_filter_metadata/README.md b/examples/filter_metadata/README.md → examples/envoy_filter_metadata/README.md
@@ -1,6 +1,6 @@
-## Proxy-Wasm plugin example: Metadata
+## Proxy-Wasm plugin example: Envoy metadata
 
-Proxy-Wasm plugin that demonstrates reading metadata set by other filters
+Proxy-Wasm plugin that demonstrates reading metadata set by other Envoy filters
 
 ### Building
 
@@ -24,10 +24,10 @@ $ curl localhost:10000/
 Welcome, set the `x-custom-metadata` header to change the response!
 ```
 
-
-Send a HTTP request to `localhost:10000/` with a `x-custom-metadata` header value.
+Send a HTTP request to `localhost:10000/` with a `x-custom-metadata` header value to get the uppercased value in the response. 
+The response will also set a response header `uppercased-metadata: SOME-VALUE`.
 
 ```sh
 $ curl localhost:10000/ -H "x-custom-metadata: some-value"
-Custom response with `x-custom-metadata` value "some-value"
+Custom response with Envoy metadata: "SOME-VALUE"!
 ```
diff --git a/examples/filter_metadata/docker-compose.yaml → ...envoy_filter_metadata/docker-compose.yaml b/examples/filter_metadata/docker-compose.yaml → ...envoy_filter_metadata/docker-compose.yaml
diff --git a/examples/filter_metadata/envoy.yaml → examples/envoy_filter_metadata/envoy.yaml b/examples/filter_metadata/envoy.yaml → examples/envoy_filter_metadata/envoy.yaml
@@ -39,7 +39,7 @@ static_resources:
                           body:
                             inline_string: "Welcome, set the `x-custom-metadata` header to change the response!\n"
               http_filters:
-                # Set metadata
+                # Set uppercase metadata in Lua filter
                 - name: envoy.filters.http.lua
                   typed_config:
                     "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua
@@ -50,7 +50,7 @@ static_resources:
                           local data = headers:get("x-custom-metadata")
 
                           if data then
-                            request_handle:streamInfo():dynamicMetadata():set("envoy.filters.http.lua", "x-custom-metadata", data)
+                            request_handle:streamInfo():dynamicMetadata():set("envoy.filters.http.lua", "uppercased-custom-metadata", string.upper(data))
                           end
 
                           request_handle:logInfo("Metadata set by lua filter")
@@ -62,12 +62,12 @@ static_resources:
                     type_url: type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm
                     value:
                       config:
-                        name: "metadata_filter"
+                        name: "envoy_metadata_filter"
                         vm_config:
                           runtime: "envoy.wasm.runtime.v8"
                           code:
                             local:
-                              filename: "/etc/envoy/proxy-wasm-plugins/proxy_wasm_example_filter_metadata.wasm"
+                              filename: "/etc/envoy/proxy-wasm-plugins/proxy_wasm_example_envoy_filter_metadata.wasm"
                 - name: envoy.filters.http.router
                   typed_config:
                     "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
diff --git a/examples/filter_metadata/src/lib.rs → examples/envoy_filter_metadata/src/lib.rs b/examples/filter_metadata/src/lib.rs → examples/envoy_filter_metadata/src/lib.rs
@@ -31,16 +31,16 @@ impl HttpContext for MetadataHttp {
             "metadata",
             "filter_metadata",
             "envoy.filters.http.lua",
-            "x-custom-metadata",
+            "uppercased-custom-metadata",
         ]) {
             Some(metadata) => match String::from_utf8(metadata) {
                 Ok(data) => {
                     self.send_http_response(
                         200,
-                        vec![("Powered-By", "proxy-wasm")],
+                        vec![("Powered-By", "proxy-wasm"), ("uppercased-metadata", &data)],
                         Some(
                             format!(
-                                "Custom response with `x-custom-metadata` value {:?}!\n",
+                                "Custom response with Envoy metadata: {:?}!\n",
                                 data
                             )
                             .as_bytes(),