Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(microsoft365): rename checks to match naming convention #7235

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3bf62f7
refactor: rename entra_admin_consent_workflow_enabled
HugoPBrito Mar 13, 2025
1ab91b0
refactor: rename entra_admin_portals_role_limited_access
HugoPBrito Mar 13, 2025
f0d4c2c
refactor: enhance entra_organization_admin_consent_workflow_enabled r…
HugoPBrito Mar 13, 2025
4ab392a
refactor: rename entra_identity_protection_sign_in_risk_enabled
HugoPBrito Mar 13, 2025
391b10d
refactor: rename entra_identity_protection_user_risk_enabled
HugoPBrito Mar 13, 2025
dab3ae4
refactor: rename entra_managed_device_required_for_authentication
HugoPBrito Mar 13, 2025
b39ec54
refactor: rename entra_ca_policy_identity_protection_sign_in_risk_ena…
HugoPBrito Mar 13, 2025
b69f79f
refactor: rename entra_ca_policy_identity_protection_user_risk_enabled
HugoPBrito Mar 13, 2025
55a8310
refactor: rename entra_policy_ensure_default_user_cannot_create_tenants
HugoPBrito Mar 13, 2025
49cd101
refactor: rename entra_dynamic_group_for_guests_created
HugoPBrito Mar 13, 2025
bf47642
refactor: rename entra_enterprise_app_admin_consent_workflow_enabled
HugoPBrito Mar 13, 2025
7a4f039
refactor: rename entra_password_hash_sync_enabled
HugoPBrito Mar 13, 2025
97616bc
feat: enhance remediation other
HugoPBrito Mar 13, 2025
0db303b
refactor: rename entra_thirdparty_integrated_apps_not_allowed
HugoPBrito Mar 13, 2025
6e22d08
refactor: rename entra_admin_users_sign_in_frequency_enabled
HugoPBrito Mar 13, 2025
bfabc65
refactor: rename entra_admin_mfa_enabled_for_administrative_roles
HugoPBrito Mar 13, 2025
be204fe
refactor: test names
HugoPBrito Mar 14, 2025
e420ff3
Revert "refactor: rename entra_policy_ensure_default_user_cannot_crea…
HugoPBrito Mar 14, 2025
5f88e5a
refactor: rename check
HugoPBrito Mar 14, 2025
2d10e40
Merge branch 'master' of https://github.com/prowler-cloud/prowler int…
HugoPBrito Mar 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: rename entra_ca_policy_identity_protection_sign_in_risk_ena…
…bled
HugoPBrito committed Mar 13, 2025

Verified

This commit was signed with the committer’s verified signature.
HugoPBrito Hugo Pereira Brito
commit b39ec544cf030758c6497f4b0272430b6b1921de
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"Provider": "microsoft365",
"CheckID": "entra_ca_policy_admin_portals_role_limited_access",
"CheckID": "entra_capolicy_admin_portals_role_limited_access",
"CheckTitle": "Ensure that only administrative roles have access to Microsoft Admin Portals",
"CheckType": [],
"ServiceName": "entra",
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
)


class entra_ca_policy_admin_portals_role_limited_access(Check):
class entra_capolicy_admin_portals_role_limited_access(Check):
"""Check if Conditional Access policies deny access to the Microsoft 365 admin center for users with limited access roles.
This check ensures that Conditional Access policies are in place to deny access to the Microsoft 365 admin center for users with limited access roles.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"Provider": "microsoft365",
"CheckID": "entra_ca_policy_identity_protection_sign_in_risk_enabled",
"CheckID": "entra_capolicy_identity_protection_sign_in_risk_enabled",
"CheckTitle": "Ensure that Identity Protection sign-in risk policies are enabled",
"CheckType": [],
"ServiceName": "entra",
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@
)


class entra_ca_policy_identity_protection_sign_in_risk_enabled(Check):
class entra_capolicy_identity_protection_sign_in_risk_enabled(Check):
"""Check if at least one Conditional Access policy is a Identity Protection sign-in risk policy.
This check ensures that at least one Conditional Access policy is a Identity Protection sign-in risk policy.
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
)


class Test_entra_ca_policy_admin_portals_role_limited_access:
class Test_entra_capolicy_admin_portals_role_limited_access:
def test_entra_no_conditional_access_policies(self):
entra_client = mock.MagicMock
entra_client.audited_tenant = "audited_tenant"
@@ -31,17 +31,17 @@ def test_entra_no_conditional_access_policies(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access import (
entra_capolicy_admin_portals_role_limited_access,
)

entra_client.conditional_access_policies = {}

check = entra_ca_policy_admin_portals_role_limited_access()
check = entra_capolicy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -66,12 +66,12 @@ def test_entra_admin_center_limited_access_disabled(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access import (
entra_capolicy_admin_portals_role_limited_access,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -112,7 +112,7 @@ def test_entra_admin_center_limited_access_disabled(self):
)
}

check = entra_ca_policy_admin_portals_role_limited_access()
check = entra_capolicy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -138,12 +138,12 @@ def test_entra_admin_center_limited_access_enabled_for_reporting(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access import (
entra_capolicy_admin_portals_role_limited_access,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -186,7 +186,7 @@ def test_entra_admin_center_limited_access_enabled_for_reporting(self):
)
}

check = entra_ca_policy_admin_portals_role_limited_access()
check = entra_capolicy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -215,12 +215,12 @@ def test_entra_admin_center_limited_access_enabled(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_capolicy_admin_portals_role_limited_access.entra_capolicy_admin_portals_role_limited_access import (
entra_capolicy_admin_portals_role_limited_access,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -263,7 +263,7 @@ def test_entra_admin_center_limited_access_enabled(self):
)
}

check = entra_ca_policy_admin_portals_role_limited_access()
check = entra_capolicy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
)


class Test_entra_ca_policy_identity_protection_sign_in_risk_enabled:
class Test_entra_capolicy_identity_protection_sign_in_risk_enabled:
def test_entra_no_conditional_access_policies(self):
entra_client = mock.MagicMock
entra_client.audited_tenant = "audited_tenant"
@@ -32,17 +32,17 @@ def test_entra_no_conditional_access_policies(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import (
entra_ca_policy_identity_protection_sign_in_risk_enabled,
from prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled import (
entra_capolicy_identity_protection_sign_in_risk_enabled,
)

entra_client.conditional_access_policies = {}

check = entra_ca_policy_identity_protection_sign_in_risk_enabled()
check = entra_capolicy_identity_protection_sign_in_risk_enabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -67,12 +67,12 @@ def test_entra_identity_protection_user_risk_policy_disabled(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import (
entra_ca_policy_identity_protection_sign_in_risk_enabled,
from prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled import (
entra_capolicy_identity_protection_sign_in_risk_enabled,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -115,7 +115,7 @@ def test_entra_identity_protection_user_risk_policy_disabled(self):
)
}

check = entra_ca_policy_identity_protection_sign_in_risk_enabled()
check = entra_capolicy_identity_protection_sign_in_risk_enabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -141,12 +141,12 @@ def test_entra_identity_protection_user_risk_policy_enabled_not_enough_risk(self
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import (
entra_ca_policy_identity_protection_sign_in_risk_enabled,
from prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled import (
entra_capolicy_identity_protection_sign_in_risk_enabled,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -194,7 +194,7 @@ def test_entra_identity_protection_user_risk_policy_enabled_not_enough_risk(self
)
}

check = entra_ca_policy_identity_protection_sign_in_risk_enabled()
check = entra_capolicy_identity_protection_sign_in_risk_enabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -223,12 +223,12 @@ def test_entra_identity_protection_user_risk_policy_enabled_for_reporting(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import (
entra_ca_policy_identity_protection_sign_in_risk_enabled,
from prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled import (
entra_capolicy_identity_protection_sign_in_risk_enabled,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -276,7 +276,7 @@ def test_entra_identity_protection_user_risk_policy_enabled_for_reporting(self):
)
}

check = entra_ca_policy_identity_protection_sign_in_risk_enabled()
check = entra_capolicy_identity_protection_sign_in_risk_enabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -305,12 +305,12 @@ def test_entra_identity_protection_user_risk_policy_enabled(self):
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import (
entra_ca_policy_identity_protection_sign_in_risk_enabled,
from prowler.providers.microsoft365.services.entra.entra_capolicy_identity_protection_sign_in_risk_enabled.entra_capolicy_identity_protection_sign_in_risk_enabled import (
entra_capolicy_identity_protection_sign_in_risk_enabled,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -358,7 +358,7 @@ def test_entra_identity_protection_user_risk_policy_enabled(self):
)
}

check = entra_ca_policy_identity_protection_sign_in_risk_enabled()
check = entra_capolicy_identity_protection_sign_in_risk_enabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"