-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detect-secrets): get secrets plugins from config.yaml #6544
base: master
Are you sure you want to change the base?
feat(detect-secrets): get secrets plugins from config.yaml #6544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6544 +/- ##
==========================================
- Coverage 89.89% 89.43% -0.46%
==========================================
Files 1182 1182
Lines 35408 33839 -1569
==========================================
- Hits 31829 30263 -1566
+ Misses 3579 3576 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I opened a Yelp/detect-secrets#910 to add a new detector for Aiven tokens. However, I doubt that it will be merged soon considering all the open, unmerged other PR's for new detectors. |
data=data, excluded_secrets=secrets_ignore_patterns | ||
data=data, | ||
excluded_secrets=secrets_ignore_patterns, | ||
detect_secrets_plugins=cloudformation_client.audit_config.get( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should get the default list of plugins instead of None
or {}
. Please review it in all checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, changes on the next commit.
Context
Fix #6522
Description
Make plugins from detect-secrets configurable.
Thanks @kagahd for the feature-request 🚀
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.