Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Update Kafka config-related info on schedule #3764

Merged
merged 33 commits into from
May 10, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented May 2, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Retrieving config-related info (version, features) on stats update

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

iliax and others added 30 commits October 20, 2022 19:37
1. Getting topic config defaults from server response
2. rm KafkaConstants
3. doc field added to TopicConfigDTO
…_acl

� Conflicts:
�	documentation/compose/kafka-ui-sasl.yaml
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/model/rbac/AccessContext.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/FeatureService.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ReactiveAdminClient.java
�	kafka-ui-contract/src/main/resources/swagger/kafka-ui-api.yaml
…_acl

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/util/KafkaVersion.java
…_acl

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/FeatureService.java
…_acl

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ReactiveAdminClient.java
@iliax iliax requested review from a team and Haarolean as code owners May 2, 2023 12:05
@iliax iliax linked an issue May 2, 2023 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label May 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

iliax added 2 commits May 2, 2023 16:37
…9_version_updates_on_schedule

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/FeatureService.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ReactiveAdminClient.java
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend and removed status/triage Issues pending maintainers triage labels May 3, 2023
@Haarolean Haarolean changed the title Kafka config-related info update on schedule BE: Update Kafka config-related info on schedule May 10, 2023
@Haarolean Haarolean merged commit aa7429e into master May 10, 2023
20 of 22 checks passed
@Haarolean Haarolean deleted the ISSUE-3749_version_updates_on_schedule branch May 10, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker version doesn't change without kafka ui restart
2 participants