Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose cluster ACL list #2818

Merged
merged 31 commits into from
May 2, 2023
Merged

Expose cluster ACL list #2818

merged 31 commits into from
May 2, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Oct 24, 2022 •
edited
Loading

  1. ACL endpoints added
  2. ACL enablement check implemented in ReactiveAdmitClient
  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

iliax added 3 commits October 20, 2022 19:37
ISSUE-2787:
4f3ae69 
1. Getting topic config defaults from server response
2. rm KafkaConstants
3. doc field added to TopicConfigDTO
ReactiveAdminClient.SupportedFeature refactor
86d931a
ISSUE-754: Backend for kafka ACLs
83bccc1
@iliax iliax requested review from a team and Haarolean as code owners October 24, 2022 21:01
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Oct 24, 2022
Base automatically changed from ISSUE_2787_topic_default_configs to master October 30, 2022 17:59
@Haarolean Haarolean linked an issue Oct 31, 2022 that may be closed by this pull request
ACL: Expose cluster's ACLs (read/only) #754
Closed
@Haarolean Haarolean changed the title ISSUE-754: ACL API Expose cluster ACL list Oct 31, 2022
@Haarolean Haarolean added scope/backend type/feature A new feature and removed status/triage Issues pending maintainers triage labels Oct 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iliax iliax linked an issue Dec 8, 2022 that may be closed by this pull request
BE: ACL management #124
Open
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

iliax and others added 6 commits March 13, 2023 22:32
Merge branch 'master' of github.com:provectus/kafka-ui into ISSUE_754…
4173f78 
…_acl

� Conflicts:
�	documentation/compose/kafka-ui-sasl.yaml
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/model/rbac/AccessContext.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/FeatureService.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ReactiveAdminClient.java
�	kafka-ui-contract/src/main/resources/swagger/kafka-ui-api.yaml
PR updated
ffff964
wip
297a1d9
@iliax
Merge branch 'master' into ISSUE_754_acl
e80096e
wip
be26f86
wip
8e5cf2b
Merge branch 'master' of github.com:provectus/kafka-ui into ISSUE_754…
8532085 
…_acl

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/util/KafkaVersion.java
tomaszc
tomaszc reviewed Apr 2, 2023
View reviewed changes
documentation/compose/jaas/kafka_server.conf Show resolved Hide resolved
documentation/compose/jaas/zookeeper_jaas.conf Show resolved Hide resolved
documentation/compose/kafka-ui-sasl.yaml Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/AclsController.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/AclsController.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/acl/AclCsv.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/acl/AclCsv.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/acl/AclCsv.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/acl/AclCsv.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ReactiveAdminClient.java Show resolved Hide resolved
iliax and others added 10 commits April 3, 2023 11:47
@iliax iliax enabled auto-merge (squash) May 2, 2023 10:19
@Haarolean Haarolean removed a link to an issue May 2, 2023
BE: ACL management #124
Open
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iliax iliax merged commit 727f384 into master May 2, 2023
10 checks passed
@iliax iliax deleted the ISSUE_754_acl branch May 2, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszc tomaszc tomaszc left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees

@iliax iliax

Labels
scope/backend type/feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACL: Expose cluster's ACLs (read/only)
3 participants
@iliax @Haarolean @tomaszc