Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 754] Define listing of Acls API #1511

Closed
wants to merge 3 commits into from
Closed

[ISSUE 754] Define listing of Acls API #1511

wants to merge 3 commits into from

Conversation

jonas-grgt
Copy link
Contributor

@jonas-grgt jonas-grgt commented Jan 28, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@jonas-grgt jonas-grgt changed the title [754] Define listing of Acls API [ISSUE 754] Define listing of Acls API Jan 28, 2022
@Haarolean Haarolean linked an issue Feb 1, 2022 that may be closed by this pull request
@Haarolean Haarolean added impact/api A PR with changes which affect API impact/changelog A PR with changes which should be addressed in the changelog explicitly scope/backend type/feature A new feature labels Feb 1, 2022
@Haarolean Haarolean self-assigned this Feb 1, 2022
@Haarolean Haarolean added status/pending-frontend and removed impact/changelog A PR with changes which should be addressed in the changelog explicitly labels Feb 1, 2022
Copy link
Contributor

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasgeiregat can we return whole AclBinding instead of AccessControlEntry?

@jonas-grgt
Copy link
Contributor Author

@jonasgeiregat can we return whole AclBinding instead of AccessControlEntry?

You mean instead of /api/clusters/{clusterName}/acls/{resourceType} just the list of all Acls per cluster like /api/clusters/{clusterName}/acls ?

@Haarolean
Copy link
Contributor

@jonasgeiregat can we return whole AclBinding instead of AccessControlEntry?

You mean instead of /api/clusters/{clusterName}/acls/{resourceType} just the list of all Acls per cluster like /api/clusters/{clusterName}/acls ?

You're returning a list of AccessControlEntry, but I'd like to see AclBinding, which is a parent entity.

type: string
enum: [UNKNOWN, ANY, DENY, ALLOW]
required:
- totalReplicationFactor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that?

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Haarolean Haarolean added the status/pending Further information is requested label Apr 5, 2022
@github-actions github-actions bot added the Stale label Apr 6, 2022
@github-actions github-actions bot closed this Apr 6, 2022
@Haarolean Haarolean reopened this Apr 6, 2022
@Haarolean Haarolean removed the Stale label Apr 6, 2022
@github-actions
Copy link

This PR has been automatically marked as stale because no requested changes have been applied. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the status/stale Stale issues will be closed in 7 days. label Apr 14, 2022
@github-actions github-actions bot closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/api A PR with changes which affect API scope/backend status/pending Further information is requested status/stale Stale issues will be closed in 7 days. type/feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL: Expose cluster's ACLs (read/only)
2 participants