Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get json to work with ? #73

Closed
wants to merge 3 commits into from
Closed

get json to work with ? #73

wants to merge 3 commits into from

Conversation

Joematpal
Copy link
Contributor

No description provided.

@Joematpal Joematpal mentioned this pull request May 19, 2023
Closed
@Joematpal
Copy link
Contributor Author

@proullon Got a second to review this?

proullon
proullon requested changes May 31, 2023
View reviewed changes
Copy link
Owner

@proullon proullon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the typo failing the test ? I'll merge right after, thanks that's way cleaner code

driver/driver_test.go

j, _ := json.Marshal(map[string]string{"a": "a"})

_, err = db.Exec("INSERT INTO test (json) values (?)", j)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table name should be "test_json" here, that's why tests are failing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I fixed it.

proullon
proullon requested changes May 31, 2023
View reviewed changes
Copy link
Owner

@proullon proullon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the typo failing the test ? I'll merge right after, thanks that's way cleaner code

@Joematpal
Copy link
Contributor Author

I doesn't seem to want to update my forked feature branch. I'm going to close an open a new pr.

@Joematpal Joematpal closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proullon proullon proullon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joematpal @proullon