Remove (Get|Mutable)ByClassData from lazy fields.#28798
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Remove (Get|Mutable)ByClassData from lazy fields.#28798copybara-service[bot] wants to merge 1 commit into
(Get|Mutable)ByClassData from lazy fields.#28798copybara-service[bot] wants to merge 1 commit into
Conversation
Callers which have a prototype should get the class data from the prototype and pass the class data. This is the same process that now happens in `GetByPrototype`, now made explicit in the caller. There's also a small optimization in `LazyField::MergeFromMessage` which avoids loading the class data twice. The redundancy was made more obvious by this refactor. PiperOrigin-RevId: 953473756
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
(Get|Mutable)ByClassDatafrom lazy fields.Callers which have a prototype should get the class data from the prototype and pass the class data. This is the same process that now happens in
GetByPrototype, now made explicit in the caller.There's also a small optimization in
LazyField::MergeFromMessagewhich avoids loading the class data twice. The redundancy was made more obvious by this refactor.