Add volatile to init_array asm#28709
Merged
Merged
Conversation
Strictly speaking we want it to always emit this without guessing about whether it thinks there are side effects. Clang and gcc already emit this because they see it taking a function pointer, but this should be more robust. PiperOrigin-RevId: 951099608
copybara-service
Bot
force-pushed
the
test_949208106
branch
from
July 20, 2026 22:57
8b12758 to
a13f6b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add volatile to init_array asm
Strictly speaking we want it to always emit this without guessing about whether it thinks there are side effects. Clang and gcc already emit this because they see it taking a function pointer, but this should be more robust.