Removed indirection for sub-messages. #24165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, we use weak definitions of actual MiniTables for tree shaking, instead of pointers to MiniTables. This means that a tree shaken MiniTable will take up `sizeof(upb_MiniTable)` space, instead of `sizeof(void*)`, which is a size regression. On the other hand, this saves `sizeof(void*)` bytes from every sub-message field, so it may be a size improvement overall. PiperOrigin-RevId: 823966877
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed indirection for sub-messages.
To do this, we use weak definitions of actual MiniTables for tree shaking, instead of pointers to MiniTables. This means that a tree shaken MiniTable will take up
sizeof(upb_MiniTable)space, instead ofsizeof(void*), which is a size regression. On the other hand, this savessizeof(void*)bytes from every sub-message field, so it may be a size improvement overall.