Fasttable: normalized the calling convention #24162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_768667743
branch
from
9e64a3a to
38ad4c1
Compare
copybara-service
bot
force-pushed
the
test_768667743
branch
from
38ad4c1 to
2c90abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fasttable: normalized the calling convention
After this CL, fasttable functions always take
upb_DecodeFastNextas a parameter, instead of having some functions return it.This helps functions compose more easily, since all functions follow the same calling convention.
Also simplified and normalized the set of
upb_DecodeFastNextvalues.