Fix #636 #688
Open
Fix #636 #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for OBO files
Adding functionality for OBO files
DownloadFormatExtension fixed, OBO supported, XML files fixed
|
@riya24899 and I were working together on this issue. Here are some screenshots of the added OBO download feature.
|
|
|
||
| OWL_XML(OWLXMLDocumentFormat::new, "application/owl+xml", DownloadFormatExtension.owx), | ||
|
|
||
| OBO(OBODocumentFormat::new, "application/octet-stream", DownloadFormatExtension.obo), |
Contributor
There was a problem hiding this comment.
Curious. Where does this Mime Type come from?
| <groupId>net.sourceforge.owlapi</groupId> | ||
| <artifactId>owlapi-gwt</artifactId> | ||
| <version>4.3.2.1-SNAPSHOT</version> | ||
| <version>4.3.2.1</version> |
Contributor
There was a problem hiding this comment.
Please can you remove this? It's since been updated.
| <groupId>net.sourceforge.owlapi</groupId> | ||
| <artifactId>owlapi-gwt</artifactId> | ||
| <version>4.3.2.1-SNAPSHOT</version> | ||
| <version>4.3.2.1</version> |
Contributor
There was a problem hiding this comment.
Please can you remove this? It's since been updated.
matthewhorridge
requested changes
Jul 7, 2020
Contributor
matthewhorridge
left a comment
matthewhorridge
left a comment
There was a problem hiding this comment.
Looks good. I've just a couple of minor comments. Easy to fix. Thanks a lot for the contribution.
matthewhorridge
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to export a project as an OBO file.