Use xdg-open to spawn browser on GNU/Linux
#1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GNU/Linux (or similar, non-macOS, non-Windows platforms), when attempting to open a URL, try using the `xdg-open` command first, before any other possible browser. This would ensure that the link is open using the user's preferred browser (assuming a FreeDesktop.org-compliant desktop environment). closes #1263
Silence some warnings in the NativeBrowserLauncher by: * avoiding using a "raw type" `Class`; * avoiding the single-argument form of `java.lang.Runtime.exec` (deprecated in Java18).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
NativeBrowserLauncherclass so that, on GNU/Linux (or similar non-macOS, non-Windows platforms), we try opening a URL usingxdg-openfirst, before any other possible browser. This ensures that the URL is opened using the user’s preferred browser (assuming a FreeDesktop.org-compliant environment, which should be the case of most if not all GNU/Linux distributions nowadays).closes #1263
Also bundled with that PR are two small changes on that same
NativeBrowserLauncherclass to silence some warnings about (1) the use of a “raw type”Classand (2) the use of the deprecated-in-Java-18java.lang.Runtime.exec(String)method.