Added scan for INST opcode (#52)

modelscan/tools/picklescanner.py

@@ -136,7 +136,7 @@ def _list_globals(
             if op_name == "MEMOIZE" and n > 0:
                 memo[len(memo)] = ops[n - 1][1]
 
-            if op_name == "GLOBAL":
+            if op_name in ["GLOBAL", "INST"]:
                 globals.add(tuple(op_value.split(" ", 1)))
             elif op_name == "STACK_GLOBAL":
                 values: List[str] = []

tests/test_modelscan.py

@@ -172,6 +172,11 @@ def file_path(tmp_path_factory: Any) -> Any:
         pickle.dumps(Malicious1(), protocol=4),
     )
 
+    malicious10_pickle_bytes = (
+        b"(S'print(\"Injection running\")'\ni__builtin__\nexec\n."
+    )
+    initialize_data_file(f"{tmp}/data/malicious10.pkl", malicious10_pickle_bytes)
+
     return tmp
 
 
@@ -577,6 +582,19 @@ def test_scan_pickle_operators(file_path: Any) -> None:
     malicious9.scan_path(Path(f"{file_path}/data/malicious9.pkl"))
     assert malicious9.issues.all_issues == expected_malicious9
 
+    expected_malicious10 = [
+        Issue(
+            IssueCode.UNSAFE_OPERATOR,
+            IssueSeverity.CRITICAL,
+            OperatorIssueDetails(
+                "__builtin__", "exec", f"{file_path}/data/malicious10.pkl"
+            ),
+        )
+    ]
+    malicious10 = Modelscan()
+    malicious10.scan_path(Path(f"{file_path}/data/malicious10.pkl"))
+    assert malicious10.issues.all_issues == expected_malicious10
+
 
 def test_scan_directory_path(file_path: str) -> None:
     expected = {
@@ -728,6 +746,13 @@ def test_scan_directory_path(file_path: str) -> None:
                 "posix", "system", f"{file_path}/data/malicious2_v0.pkl"
             ),
         ),
+        Issue(
+            IssueCode.UNSAFE_OPERATOR,
+            IssueSeverity.CRITICAL,
+            OperatorIssueDetails(
+                "__builtin__", "exec", f"{file_path}/data/malicious10.pkl"
+            ),
+        ),
     }
     ms = Modelscan()
     p = Path(f"{file_path}/data/")