Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $includeForeignObjects in ObjectCollection::toArray() parameters #1472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add $includeForeignObjects in ObjectCollection::toArray() parameters #1472

wants to merge 1 commit into from
+3 −2

Conversation

ioannis-papikas
Copy link

This Pull Request solves the issue #1471

@dereuromark
Copy link
Contributor

Can you also rebase on top of latest master?
Then we should be able to proceed.

@dereuromark dereuromark added the Bug label Jul 1, 2020
Incognito
Incognito suggested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@Incognito Incognito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added feature should get new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Incognito Incognito Incognito requested changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioannis-papikas @dereuromark @Incognito