Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct deprecated methods in PHP7.4 (#1079) #1080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michalmagic42
Copy link

  • runtime/lib/query/Join.php
    implode() was used against the definition (wrong PHP documentation

  • runtime/lib/query/ModelCriteria.php
    count() was used on non-countable variable (non-array)

* runtime/lib/query/Join.php
  implode() was used against the definition (wrong PHP documentation

* runtime/lib/query/ModelCriteria.php
  count() was used on non-countable variable (non-array)
@michalmagic42 michalmagic42 force-pushed the michal/1079/correct-deprecated-methods-for-php-7.4 branch from 489b8cd to 8b24c58 Compare March 16, 2020 12:49
@RickJeroen
Copy link

Would be really great if someone can merge this request! :)

@romantymoshyk
Copy link

@michalmagic42 , could you please also perform next compatibility changes in scope of your pull request? Replace curly braces with square brackets(https://wiki.php.net/rfc/deprecate_curly_braces_array_access):
GeneratorConfig.php:124
QuickGeneratorConfig.php:65
BasePeer.php:400

@Robbt
Copy link

Robbt commented May 6, 2020

Hey everybody just noticed that my project LibreTime is running into this with our attempt to support php 7.4 - anything I can do to help move along the process ?

@RickJeroen
Copy link

Hey everybody just noticed that my project LibreTime is running into this with our attempt to support php 7.4 - anything I can do to help move along the process ?

Same here! I'm also willing to help

@Robbt
Copy link

Robbt commented May 6, 2020

It seems the request is that all of the 7.4 compatibility fixes be done in one PR, not sure if @michalmagic42 is still paying attention to this, if not should somebody open up a new PR to handle those requested by @romantymoshyk as well as the fixes that are this PR ?

@michalmagic42
Copy link
Author

It seems the request is that all of the 7.4 compatibility fixes be done in one PR, not sure if @michalmagic42 is still paying attention to this, if not should somebody open up a new PR to handle those requested by @romantymoshyk as well as the fixes that are this PR ?

Technically, I cannot find the time to handle changes proposed by @romantymoshyk
I will try to do it during the incoming week. The same as you guys, I'm a developer who waits for new release as at the moment I have to work on patched vendor source.

@Robbt
Copy link

Robbt commented May 6, 2020

I opened up a new PR that fixes the curly brace changes that were requested above by @romantymoshyk , so hopefully they can both be merged or else combined (if that is desired by the maintainers). Let me know if there is anything else I can do to help.

@michalmagic42
Copy link
Author

I opened up a new PR that fixes the curly brace changes that were requested above by @romantymoshyk , so hopefully they can both be merged or else combined (if that is desired by the maintainers). Let me know if there is anything else I can do to help.

@Robbt your PR failed on checking. Please correct the PR, otherwise, there is no chance to have the PR merged.

@tworzenieweb
Copy link

I made a lot of effort within my PR to have everything running with PHP7.4 also modernizing the stack (phpunit etc.) to work inside of our migrated to php7.4 project. #1086

@RickJeroen
Copy link

Any updates on this one? Can I help to get this PR merged?

@tworzenieweb
Copy link

Any updates on this one? Can I help to get this PR merged?

I did all the heavy lifting for PHP7.4 in #1086

if you want to help then please have a look there

@deargle
Copy link

deargle commented Nov 14, 2020

heads up that hostmonster just pushed php7.4 as the default on maybe everyone, its cPanel overriding a manual php version pinning which I had set in .htaccess with its own later addhandler specification_ ಠ_ಠ, which led to my site not loading, eventually leading me to this github issue. I eventually fumbled my way to the cPanel "Programming > PHP Config" area, where I could (re)set my own default, down to 7.3, which removes the addhandler that they had added, so I don't think it will get magically re-added again 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants