Repository navigation
secret_setup: a one-shot names python3 as its entrypoint (CI for alpha/rc2, not for merge) - #136
Merged
Merged
Conversation
The writer's one-shot ran `<image> python3 -I -S /w/host_steps.py ...`,
which hands "python3" to the image's ENTRYPOINT as its first argument.
The hub-link router's image declares /app/docker/entrypoint.sh, a mode
dispatcher, and refused it on the alpha VM ("entrypoint: unknown mode
'python3'") at host-setup plan line 42, the volume root step. The same
argv shape is used by verify's stat-secret one-shot and by the B5
writer route, so each would refuse the same way.
oneshot() now passes `--entrypoint python3` before the image and only
python3's arguments after it, as router_fingerprint and partition_probe
already do. The probe and the runtime itself still run through the
image's own entrypoint and mode.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, for CI only. This pull request exists so that the required checks,
suite (3.9)andsuite (3.13), run onc0113f3 before alpha/rc2 is fast-forwarded to it. It is not merged: alpha/rc2 moves by a reviewed fast-forward push of
the same commit, and this pull request is then closed. Its branch is deleted only on the operator's word.
The writer's one-shot ran
<image> python3 -I -S /w/host_steps.py ..., which hands "python3" to the image's ENTRYPOINTas its first argument. The hub-link router's image declares a mode dispatcher as its entrypoint, which refuses an
unknown mode, so the one-shot root step of the rendered host plan stopped there. The stat one-shot (verify's volume
check) and the B5 writer route use the same argv shape.
oneshot()now passes--entrypoint python3before the image and only python3's arguments after it, asrouter_fingerprintandpartition_probealready do. The probe and the runtime still run through the image's ownentrypoint and mode. host_steps.py is unchanged.
Tests:
tests/test_secret_setup.pyasserts the plan's root line, the live stat argv, and every one-shot role (root,writer, stat) name python3 as the entrypoint, with the image followed by python3's arguments only.
🤖 Generated with Claude Code