Repository navigation
verify: A5's texts start and read the local router by its image Id and container - #131
Merged
Merged
Conversation
…d container
Three texts an operator meets at A5 named docker/run.sh or verify
without an image, so they started or read whatever image carries
run.sh's default name, not the one A4 started:
- hub_keys' binding remedy ("start the local router with docker/run.sh
--config ..."), reached from verify's host-setup section and from
hub_keys.checks. It now names the host-setup document's router
section by --image <digest> --name <container> --detach
(run_sh_start); both callers pass spec.router. Without a router
section it is unchanged.
- router_health's absent-container remedy, which now names verify's own
--image beside the --name it already gave.
- A5's printed verify line (activation_sequence) and the runbook's final
A5 step, which now pass --image <router.image.digest> --container
<router.container>, since verify's --container also defaults to
run.sh's name.
Each is pinned by a test that varies only the router section, or only
verify's --image, and requires the printed value to follow it; the
call sites are pinned by tests that read what reaches the binding.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three texts an operator meets at A5 name
docker/run.shorverifywithout an image. Each starts or reads whatever image carries run.sh's default name, not the one A4 started.hub_keys). It is reached from verify's host-setup section and fromhub_keys.checks.--image <digest> --name <container> --detach, throughrun_sh_start.spec.router.router_health). It now names verify's own--image, beside the--nameit already gave.--image <router.image.digest> --container <router.container>, because verify's--containeralso defaults to run.sh's name.Tests:
--image, and requires the printed value to follow it.This follows #127, which fixed A4's own line.
Based on
m1/c-8a515c10, notmain. Held as a draft. Merge is the operator's own decision.🤖 Generated with Claude Code