Removed funcbench from this repository. #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was fun to develop it and use for a while. However, currently it was not used for long (AFAIK), and definitely not maintained/updated for a while. Other communities (e.g. Otel) started to use [dedicated OSS action](https://github.com/benchmark-action/github-action-benchmark) which looks promising. I propose we remove the funcbench from our repo to not confuse users or our devs that such logic "should" work on our repo. Signed-off-by: bwplotka <[email protected]> # Conflicts: # funcbench/bench.go # funcbench/env.go # funcbench/main.go # go.mod
bwplotka
force-pushed
the
funcbench-rm
branch
from
d884531
to
ad1ab19
Compare
|
@bwplotka FWIW, I have plans to build a dedicated tool for this. Thanks for sharing the github-action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was fun to develop it and use for a while. However, currently it was not used for long (AFAIK), and definitely not maintained/updated for a while.
Other communities (e.g. Otel) started to use dedicated OSS action which looks promising.
I propose we remove the funcbench from our repo to not confuse users or our devs that such logic "should" work on our repo.