Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prombench: Added parca for continous profiling support. #595

Merged
merged 2 commits into from
Sep 6, 2023
Merged

prombench: Added parca for continous profiling support. #595

merged 2 commits into from
Sep 6, 2023

Conversation

bwplotka
Copy link
Member

Fixes #552

@bwplotka
Copy link
Member Author

bwplotka commented Aug 25, 2023 •
edited
Loading

Almost there Done

  • Prometheus listens for profiles on dynamic path (due to web prefix being applied to pprof paths too - might require Prometheus code change)
  • Update comment tool to give exact path for interesting profiles

@bwplotka bwplotka marked this pull request as ready for review August 30, 2023 10:34
@bwplotka
Copy link
Member Author

image

bboreham
bboreham reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I had a couple of questions.

prombench/manifests/cluster-infra/8b_parca.yaml Show resolved Hide resolved
prombench/manifests/cluster-infra/8b_parca.yaml Outdated Show resolved Hide resolved
@bwplotka bwplotka merged commit 77524ce into master Sep 6, 2023
@bwplotka bwplotka deleted the parca branch September 6, 2023 07:05
kushalShukla-web pushed a commit to kushalShukla-web/test-infra that referenced this pull request Feb 8, 2025
@bwplotka
prombench: Added parca for continous profiling support. (prometheus#595)
2e3bb8a 
* prombench: Added parca for continous profiling support.

Fixes prometheus#552

Signed-off-by: bwplotka <[email protected]>

* Addressed Bryan comment.
Signed-off-by: bwplotka <[email protected]>

---------

Signed-off-by: bwplotka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham left review comments

@nicolastakashi nicolastakashi nicolastakashi left review comments

@metalmatze metalmatze metalmatze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Continuous Profiling to Prombench for meta observability
4 participants
@bwplotka @metalmatze @bboreham @nicolastakashi