Added 'collector.disable-go-runtime-metrics' flag #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amir-Hadadi <[email protected]>
Amir-Hadadi
force-pushed
the
go-runtime-metrics-flag
branch
from
0d6c386 to
89c60f1
Compare
|
As discussed in the linked mail thread, I believe we should do this in a consistent way between exporters, ideally in https://github.com/prometheus/exporter-toolkit . (Note that this PR does something different to the existing flag in node_exporter, both in behavior and name of the flag.) |
|
See also prometheus/exporter-toolkit#119 |
|
Thank you @beorn7 – I agree that this should be directly in exporter-toolkit, and consistent across exporters. I'll close this PR not as a "I don't want this" but as a "please do this in exporter-toolkit instead, and we can then pick it up here" 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag controls go runtime metrics collection by the exporter.
The default scenario is collecting the go runtime metrics using the default go Prometheus client, using this flag means we want to disable collection. It defaults to false.
Discussion and more info is here.