Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and cut 1.7.0 #616

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Update dependencies and cut 1.7.0 #616

merged 3 commits into from
Jan 19, 2024

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jan 18, 2024

The release will implicitly use Go1.21.6.

@beorn7 beorn7 requested a review from SuperQ January 18, 2024 14:18
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove flags: -a -tags netgo from .promu.yml?

Also update go 1.20 in go.mod.

@beorn7
Copy link
Member Author

beorn7 commented Jan 18, 2024

Could you give me context why these changes are required? I seem to be a bit out of touch.

@SuperQ
Copy link
Member

SuperQ commented Jan 18, 2024

Not required, but the we determined that the flags weren't necessary anymore and the promu default is fine. Just cleanup.

The go update directive is needed by the new version of prometheus/common.

@beorn7
Copy link
Member Author

beorn7 commented Jan 18, 2024

Thank you very much.

The prometheus/common dependency is updated to 0.46.0 even if I lease the go directive at 1.19.
As far as I understand, a recent Go compiler will compile the source code of each module according to its go directive. So we could also leave it at 1.19.

But since we don't get any breakage with 1.20 (I think Go will only introduce that for later releases), we can as well signal that you need a 1.20 capable compiler to compile at all because of prometheus/common.

@beorn7
Copy link
Member Author

beorn7 commented Jan 18, 2024

Change pushed. PHAL.

@beorn7 beorn7 merged commit 109280c into master Jan 19, 2024
5 checks passed
@beorn7 beorn7 deleted the beorn7/release branch January 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants