Keep record of unwinded containers on page refresh #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution retains a record of the currently un-collapsed container and unwinds it on a page refresh. No extra refresh button and no live-update. The minor inconvenience of this solution is that on a page refresh the unwind animation plays. Helps prometheus#568 Signed-off-by: Julien Midedji <[email protected]>
|
@beorn7 would you have a look? |
|
On my list. |
|
I think this is quite good for a start. But maybe we should use the session storage rather than the local storage? A user might open different windows with different views on the same PGW. Also, it might confusing if you come back to the PGW UI after some time and get elements expanded because they are still persisted in your local storage. You might also get garbage left behind, maybe even leading to multiple elements getting expanded on reload. |
Signed-off-by: Julien Midedji <[email protected]>
|
You're right, I replaced it with |
beorn7
requested changes
Oct 14, 2023
Signed-off-by: Julien Midedji <[email protected]>
Alright, done. Thanks, I appreciate the guidance and your time in reviewing this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution retains a record of the currently un-collapsed container and unwinds it on a page refresh.
No extra refresh button and no live-update.
The minor inconvenience of this solution is that on a page refresh the unwind animation plays.
Screencast.from.2023-10-02.18-40-31.webm
Helps #568