Add option to disable STATS SETTINGS #128
Closed
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support mcrouter, add a flag to disable the collection of "STATS SETTINGS". Fixes: #113 Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/stats_settings
branch
from
67be33a
to
8b4b5a4
Compare
|
Going to leave this draft for now, there are a bunch of issues in the memcached library that need work before mcrouter will be supported. |
|
Changing this to support mcrouter will take a bunch of work on the memcached Go library. I don't have time for this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support mcrouter, add a flag to disable the collection of
"STATS SETTINGS".
Fixes: #113
Signed-off-by: SuperQ [email protected]