Intern MBean names used in cache (#1098)

Use string interning when creating the "matchName" used in the caching data structure, in order to reuse previously created String objects and to avoid duplication of Strings with identical contents in memory. Signed-off-by: Yana Ilieva <[email protected]>
prometheus · Dec 13, 2024 · 4354210 · 4354210
1 parent 1f6f6af
commit 4354210
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/collector/src/main/java/io/prometheus/jmx/JmxCollector.java b/collector/src/main/java/io/prometheus/jmx/JmxCollector.java
@@ -581,7 +581,7 @@ public void recordBean(
                     attributeName = attrName;
                 }
 
-                String matchName = beanName + attributeName + ": " + matchBeanValue;
+                String matchName = (beanName + attributeName + ": " + matchBeanValue).intern();
 
                 if (rule.cache) {
                     MatchedRule cachedRule = config.rulesCache.get(rule, matchName);