Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 write + query endpoints #95

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Mar 1, 2022

I ran into a use case where I needed a v2 client to write to the exporter. Although there might be some endpoints of interest, simply pointing my v2 client at http://localhost:9122 allowed for the metrics to write. One thing to note is this ignores all the token, org, and buckets feature set provided with v2.

Its worth noting the contributing doc didn't specify updating the version file.

Relates #80

@matthiasr

Signed-off-by: Daniel Quackenbush <[email protected]>
@matthiasr
Copy link
Contributor

This is great! Could you add a note to the README about v2 support and document the limitations there?

@matthiasr
Copy link
Contributor

Its worth noting the contributing doc didn't specify updating the version file

That's right, I do that when I cut a release. Generally multiple PRs go into one release, in different order than they were submitted; it's only in this relatively quiet repository that I cut a release after every significant change.

Signed-off-by: Daniel Quackenbush <[email protected]>
@matthiasr
Copy link
Contributor

Thank you!

@matthiasr matthiasr merged commit 50324fe into prometheus:master Mar 8, 2022
matthiasr added a commit that referenced this pull request Mar 8, 2022
for #95

Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants