Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find new versions by parsing json #249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gitperr
Copy link
Contributor

@gitperr gitperr commented Feb 21, 2024

@SuperQ one attempt at fixing: #216

This should keep the current functionality as far as my testing goes. Now just getting the versions from the said json file.

What do you think?

Keeping the current functionality, but just changing
how the version numbers are found. Instead of issuing
HEAD requests, parse https://go.dev/dl/?mode=json for
available versions and compare with what we currently
have in the repo.
Signed-off-by: Alper Polat <[email protected]>
cmd/builder-bumper/main.go Outdated Show resolved Hide resolved
cmd/builder-bumper/main.go Outdated Show resolved Hide resolved
`url` is now constant, no extra work for string
replacing anymore.
Signed-off-by: Alper Polat <[email protected]>
@gitperr
Copy link
Contributor Author

gitperr commented Feb 22, 2024

Is checking maximum of 40 minor revisions okay? Last I took a look at Go releases, they had like 20 something minor revisions max.

for next.minor < 40 {

or do you have another suggestion?

@gitperr
Copy link
Contributor Author

gitperr commented Mar 8, 2024

Does this need any other work, or is it good to merge?

@gitperr
Copy link
Contributor Author

gitperr commented Mar 19, 2024

@SuperQ this could be merged if there is no need for more changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants