Fix builder internal naming #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the readability of the builder-bumper by using semver naming for Go version components. Signed-off-by: SuperQ <[email protected]>
|
It's more consistent with Semver but less consistent with what the Go project says, e.g.
I don't mind the change, but maybe you could put one or two comments in noting the use of terminology? |
|
Yea, I find it weird that Go tells everyone to use semver for Go modules, but doesn't use semver correctly itself. |
discordianfish
approved these changes
Feb 13, 2024
|
I think I'm going to leave this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the readability of the builder-bumper by using semver naming for Go version components.