Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct base image in 1.21/main #234

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

mahendrapaipuri
Copy link
Contributor

Hello,

Looking into tag 1.21-main, I found that the base image is incorrect. Tag 1.21-main is using 1.19-base as base image and hence, go version inside the container is still 1.19.

This can be verified as follows:

docker run -v $PWD:/app -it --rm --entrypoint /bin/bash quay.io/prometheus/golang-builder:1.21-main
root@bb3024ca8c3f:/app# go version
go version go1.19.12 linux/amd64
root@bb3024ca8c3f:/app# which go
/usr/local/go/bin/go

This PR corrects the base image tag to use 1.21-base.

@mahendrapaipuri
Copy link
Contributor Author

mahendrapaipuri commented Dec 5, 2023

@SuperQ can you please take a look into it? We are currently blocked by go version in the image. Cheers!

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange, I wonder if the version upgrade handler has a bug.

@SuperQ SuperQ merged commit 5163c5f into prometheus:master Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants