OM 2.0: Remove MetricPoint concept, and use Sample#2894
Merged
dashpole merged 8 commits intoprometheus:mainfrom Mar 17, 2026
Merged
OM 2.0: Remove MetricPoint concept, and use Sample#2894dashpole merged 8 commits intoprometheus:mainfrom
dashpole merged 8 commits intoprometheus:mainfrom
Conversation
dashpole
force-pushed
the
metricpoint_to_sample
branch
2 times, most recently
from
65176e7 to
4c240ac
Compare
bwplotka
reviewed
Mar 13, 2026
dashpole
force-pushed
the
metricpoint_to_sample
branch
from
c1aed15 to
aad8d1d
Compare
Contributor
Author
|
I addressed all the open comments! |
krajorama
reviewed
Mar 16, 2026
|
|
||
| The MetricFamily name for Info metrics MUST end in `_info`. | ||
|
|
||
| A MetricPoint of an Info Metric contains a LabelSet. An Info MetricPoint's LabelSet MUST NOT have a label name which is the same as the name of a label of the LabelSet of its Metric. |
Member
There was a problem hiding this comment.
Maybe we should add in "Metric" that labels not specific to a MetricFamily that do not change over the lifetime of the process SHOULD go into an info metric ? To pair with the first sentence in this "Info" section?
bwplotka
previously approved these changes
Mar 17, 2026
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM modulo @krajorama comments
Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
metricpoint_to_sample
branch
from
857991e to
00b6c6d
Compare
bwplotka
previously approved these changes
Mar 17, 2026
Contributor
Author
|
@bwplotka I added a link to #stateset-1, but it seems like the markdown validation doesn't recognize it. This link seems to work: https://prometheus.io/docs/specs/om/open_metrics_spec_2_0/#stateset-1 |
Contributor
Author
|
I'm going to remove the link, and add it in a follow-up so we can merge this. |
Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
metricpoint_to_sample
branch
from
00b6c6d to
d2a9842
Compare
Contributor
Author
|
Removed the link |
Contributor
Author
|
Needs new approval |
krajorama
added a commit
that referenced
this pull request
Mar 18, 2026
Follow up to #2894 Let the metric be name and labels AND sample. Also fix a typo picked up by Claude. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added a commit
that referenced
this pull request
Mar 18, 2026
Follow up to #2894 Let the metric be name and labels AND sample. Also fix a typo picked up by Claude. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/OpenMetrics#315
This aligns with the structure in slide 2 of prometheus/OpenMetrics#315 (comment)