feat(om2.0): have one line for classic-native histogram#2863
Merged
Conversation
dashpole
reviewed
Mar 4, 2026
dashpole
reviewed
Mar 4, 2026
dashpole
reviewed
Mar 4, 2026
dashpole
reviewed
Mar 4, 2026
dashpole
reviewed
Mar 4, 2026
krajorama
commented
Mar 5, 2026
|
|
||
| If present, the MetricPoint's Start Timestamp MUST be inlined with the Metric point with a `st@` prefix. If the value's timestamp is present, the Start Timestamp MUST be added right after it. If exemplars are present, the Start Timestamp MUST be added before it. | ||
|
|
||
| Exemplars without Labels MUST represent an empty LabelSet as {}. |
Member
Author
There was a problem hiding this comment.
Note to reviewers: let's move this to some common place.
krajorama
commented
Mar 5, 2026
| An example of Exemplars showcasing several valid cases: | ||
| The Histogram Sample with Native Buckets has multiple Exemplars. | ||
| The "0.01" bucket has no Exemplar. The 0.1 bucket has an Exemplar with no Labels. The 1 bucket has an Exemplar with one Label. The 10 bucket has an Exemplar with a Label and a timestamp. In practice all buckets SHOULD have the same style of Exemplars. | ||
| Exemplars of a MetricPoint SHOULD have the same Label names to have a consistent style. |
Member
Author
There was a problem hiding this comment.
Note to reviewers: let's move this to some common place.
dashpole
reviewed
Mar 9, 2026
Otherwise rules around label set uniqeness, timestamps are violated. Also this should be more consistent and easier on the implementation. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/om2-single-line
branch
from
4d91df6 to
3e8e599
Compare
dashpole
approved these changes
Mar 11, 2026
bwplotka
reviewed
Mar 11, 2026
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Looks good, but I need to read through it again
bwplotka
reviewed
Mar 13, 2026
| #### Histogram with both Classic and Native Buckets | ||
|
|
||
| If a Histogram MetricPoint has both Classic and Native buckets, the Sample for the Native Buckets MUST come first. | ||
| The MetricPoint's value MUST be a CompositeValue. |
bwplotka
reviewed
Mar 13, 2026
| the exposer MAY attach only one set for performance and backwards compatibility reasons, and | ||
| that set SHOULD be the exemplars associated with Classic Buckets. | ||
|
|
||
| If present, the MetricPoint's Start Timestamp MUST be inlined with the Metric point with a `st@` prefix. |
Member
There was a problem hiding this comment.
Why we need to repeat this? Isn' this the same as everywhere else?
bwplotka
reviewed
Mar 13, 2026
| If a GaugeHistogram MetricPoint has both Classic and Native buckets, the Sample for the Native Buckets MUST come first. | ||
|
|
||
| The order ensures that implementations can easily skip the Classic Buckets if the Native Buckets are preferred. | ||
| GaugeHistogram MetricPoints with both Classic and Native Buckets follow the same syntax as Histogram MetricPoints with both Classic and Native Buckets. |
bwplotka
approved these changes
Mar 13, 2026
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM with some suggestions. I noted all as todos in our WG doc. let's merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise rules around label set uniqeness, timestamps are violated. Also this should be more consistent and easier on the implementation.