Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for UTF8 usage #2546

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add guide for UTF8 usage #2546

merged 1 commit into from
Nov 13, 2024

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Nov 13, 2024

I thought it would be useful to have one place that covers UTF-8 from end-to-end -- scrape configuration, instrumentation, and querying.

@ywwg ywwg marked this pull request as ready for review November 13, 2024 17:40
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just some suggestions, thanks!

content/docs/guides/utf8.md Outdated Show resolved Hide resolved
content/docs/guides/utf8.md Outdated Show resolved Hide resolved
content/docs/guides/utf8.md Outdated Show resolved Hide resolved
content/docs/guides/utf8.md Show resolved Hide resolved
content/docs/guides/utf8.md Show resolved Hide resolved
content/docs/guides/utf8.md Outdated Show resolved Hide resolved
Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Owen Williams <[email protected]>
@ywwg
Copy link
Member Author

ywwg commented Nov 13, 2024

squashed down and added coauthor line

@bwplotka bwplotka merged commit 96ea453 into main Nov 13, 2024
5 checks passed
@bwplotka bwplotka deleted the owilliams/utf8 branch November 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants