Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Summary metric type #254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tisonkun
Copy link

This closes #40.

This follows up #67.

With ...

@tisonkun
Copy link
Author

cc @mxinden

Comment on lines +9 to +10
#[cfg(feature = "summary")]
pub mod summary;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we add this line...

Suggested change
#[cfg(feature = "summary")]
pub mod summary;
#[cfg(feature = "summary")]
#[cfg_attr(docsrs, doc(cfg(feature = "macros")))]
pub mod summary;

we'll also make sure that this shows up in the documentation generated on docs.rs, see: https://doc.rust-lang.org/rustdoc/unstable-features.html#doccfg-recording-what-platforms-or-features-are-required-for-code-to-be-present

n.b. we'd need to also add this above in lib.rs, if it's not already present:

#![cfg_attr(docsrs, feature(doc_cfg))]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this trick for my crates and I'm glad to include this.

However, it seems a separated topic to this PR so I'd like to listen to maintainer's idea whether we should include it in this PR or add in a follow-up. Both works for me but different maintainers would have different preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Summary metric
2 participants