Clear up remaining truthiness issues. - #839
Open
jdmarshall wants to merge 1 commit into
Open
jdmarshall wants to merge 1 commit into
jdmarshall wants to merge 1 commit into
Conversation
Fixes prometheus#823 Signed-off-by: Jason Marshall <jdmarshall@users.noreply.github.com>
cjihrig
approved these changes
Sep 1, 2026
jdmarshall
changed the title
krajorama
reviewed
Sep 10, 2026
| ); | ||
| } | ||
|
|
||
| if (this.collect && typeof this.collect !== 'function') { |
Contributor
Author
There was a problem hiding this comment.
I noticed that one. The use of nullish values in constructors shows up in the tests and so I suspect some people must be using it in their code. But passing 0 in could cause some chicanery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue has gotten great contributions from the community but a few have been overlooked, particularly in the tests.
Clearing up the rest so that code tools stop complaining.
This should be a slight performance improvement over a handful of code paths.