Please consider adding a getClusterMetricsAsJSON funtion

[PatrLind]

At the moment it seems the cluster metrics are only available in the string format and not the JSON format.
I seems like it would be trivial to also add the JSON variant to the clusterMetrics function as well.
This way it would mirror how the non clustered metrics Registry interface work.

[SimenB]

Feel free to send a PR 🙂

[jdmarshall]

Given recent improvements in the JSON implementation, I'm wondering if it would be fruitful to aggregate the data from each worker thread as objects instead of strings. And there's a particular path for sendMessage/postMessage that is possibly faster still.

The alternative would be a JSON schema, which can generate an optimized emitter.

Based on the issue backlog I have some concerns about the current version of the code and p95 perturbations introduced by the aggregation load from this library. I'd love to hear more ideas for reducing that yet further.

[jdmarshall]

There's only a few lines of code needed here. Almost all of the difficulty would be creating unit tests and updating the typescript file.

The work would be extracting nearly all of clusterMetrics() to a private function, modifying #gather() to return the Registry instead of the metrics, and then either calling getMetricsAsArray() or metrics() within the two functions exposed in the API.

If someone needs this, the solution I propose is performance neutral, and I don't anticipate much if any maintenance overhead by supporting two thin wrappers around the body. I just don't want anyone trying to copy that beast of a function and making two versions.

[nirupam-06]

Hi, I’d like to work on this issue. Could you please assign it to me?4

[jdmarshall]

No rush at all on this, I'm just trying to keep on top of bookkeeping, @nirupam-06 any progress on this?

[nirupam-06]

Hi @jdmarshall — looks like #849 already covers this (getClusterMetricsAsJSON on both AggregatorRegistry and ClusterRegistry, tests passing, one approval already). No need for me to duplicate that work, so feel free to unassign me from #470. Thanks for the nudge earlier!