-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix build of JDK versions #658
base: main
Are you sure you want to change the base?
Conversation
Something was broken with the CircleCI webhook. I removed the integration and re-added. Looks like it's building again. |
FYI: I added TestContainers as part of my OpenTelemetry exemplars branch to test compatibility with different Java versions (including Java 6, which causes the most problems): Lines 35 to 43 in 103eb59
It's not merged yet. These are two different things: The TestContainers tests make sure that the binary It would be perfectly fine if we require Java 11 to build |
TestContainers use Docker to run tests against Docker containers. In order to make them work with CircleCI, we need to switch to machine images: client_java/.circleci/config.yml Lines 1 to 18 in 103eb59
Not sure if we can convert your PR to use machine images. |
I like the idea to have a clear definition which Java versions can be used to build |
We can run the So basically something like this: jobs:
test_containers:
steps:
- checkout
- setup_remote_docker
- run: docker docker docker |
I am hoping to get the OpenTelemetry exemplars branch done this week. I'll try the |
Test build on various OpenJDK versions. Signed-off-by: SuperQ <[email protected]>
Note: |
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Also add builds for Java 11 and Java 17 Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
* Replaces existing build ** Didn't enable other builds as there are currently failures. Fixes prometheus#743 Relates prometheus#658 Signed-off-by: Harold Dost <[email protected]>
Test build on various OpenJDK versions.
Signed-off-by: SuperQ [email protected]