Skip to content

perf: avoid allocating a mapping lambda on every labelValues() call #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-mollitor-db wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −14
Open

perf: avoid allocating a mapping lambda on every labelValues() call #2442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/StatefulMetric.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,20 +116,20 @@ public D labelValues(String... labelValues) {
"Expected " + labelNames.length + " label values, but got " + labelValues.length + ".");
}
}
return data.computeIfAbsent(
Arrays.asList(labelValues),
l -> {
for (int i = 0; i < l.size(); i++) {
if (l.get(i) == null) {
throw new IllegalArgumentException(
"null label value for metric "
+ metadata.getName()
+ " and label "
+ labelNames[i]);
}
}
return newDataPoint();
});
List<String> key = Arrays.asList(labelValues);
// Fast path: the data point for these label values almost always already exists, since the same
// label combinations are reused across updates.
T dataPoint = data.get(key);
if (dataPoint != null) {
return dataPoint;
}
for (int i = 0; i < labelValues.length; i++) {
if (labelValues[i] == null) {
throw new IllegalArgumentException(
"null label value for metric " + metadata.getName() + " and label " + labelNames[i]);
}
}
return data.computeIfAbsent(key, l -> newDataPoint());
}

/**
Expand Down