Include created timestamp in protobuf output format #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
reviewed
Nov 4, 2024
| this(false); | ||
| } | ||
|
|
||
| public PrometheusProtobufWriter(boolean writeCreatedTimestamps) { |
There was a problem hiding this comment.
I'd like to avoid boolean params - let's use a builder instread
There was a problem hiding this comment.
Should this even be configurable? It makes sense to make timestamps configurable in text format, because in text format timestamps end up as extra time series which cause extra load on the Prometheus server.
However, in protobuf format time stamps do not cause extra cost, so we could just enable them always, right?
There was a problem hiding this comment.
@fstab This makes sense. It should make almost no difference in protobuf. So I am thinking of removing the boolean-constructor (@zeitlinger) and make protobuf always include the created-timestamp (as long it is not null).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is actually needed for the feature "created-timestamp-zero-ingestion", which work with the protobuf-protocoll.