fix: add very small delay between observations in TestHistogramAtomicObserve
#1691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Test
TestHistogramAtomicObserve
taking too long to complete after introducing this change:Analysis
@ywwg pointed out that increase for this test runtime were introduced after adding exponential back-off to histograms.
If we will take a look at this test closely we will see that observations here
introduced in a very high pace inside tight loop without any delay or limit.
waitForCooldown
function in theWrite
method, as observations are delayed.Solution
Under typical workloads, contention is usually not as extreme as in this test. Observations has at least some delays between them. So proposal is to alter test by adding nanosecond sleep to it, which significantly reduce runtime and makes it a little bit closer to what happens typically in production.