Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable usestdlibvars linter #1680

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: enable usestdlibvars linter #1680

merged 1 commit into from
Nov 11, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

usestdlibvars detect the possibility to use variables/constants from the Go standard library.

kakkoyun
kakkoyun approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ Thanks for the contribution.

@kakkoyun kakkoyun merged commit bab92a7 into prometheus:main Nov 11, 2024
10 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/usestdlibvars branch November 11, 2024 14:27
shivanthzen pushed a commit to shivanthzen/client_golang that referenced this pull request Nov 13, 2024
@mmorel-35 @shivanthzen
chore: enable usestdlibvars linter (prometheus#1680)
954a5c0 
Signed-off-by: Matthieu MOREL <[email protected]>
amberpixels pushed a commit to amberpixels/prometheus_client_golang that referenced this pull request Nov 29, 2024
@mmorel-35 @amberpixels
chore: enable usestdlibvars linter (prometheus#1680)
645b842 
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Eugene <[email protected]>
This was referenced Feb 19, 2025
Open
Open
@dghubble-renovate dghubble-renovate bot mentioned this pull request Feb 19, 2025
Merged
1 task
@mr-borboto mr-borboto bot mentioned this pull request Feb 19, 2025
Open
1 task
@pull-bunyan pull-bunyan bot mentioned this pull request Feb 19, 2025
Open
1 task
@pb-renovate pb-renovate bot mentioned this pull request Feb 19, 2025
Open
1 task
@theriver-bot theriver-bot bot mentioned this pull request Feb 19, 2025
Merged
1 task
@larsl-renovate larsl-renovate bot mentioned this pull request Feb 19, 2025
Open
1 task
@cilium-renovate cilium-renovate bot mentioned this pull request Feb 17, 2025
Merged
1 task
This was referenced Feb 19, 2025
Merged
Merged
Merged
Open
@rwunderer rwunderer mentioned this pull request Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
This was referenced Feb 20, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@renovate renovate bot mentioned this pull request Feb 20, 2025
Open
1 task
This was referenced Feb 20, 2025
Merged
Merged
@kharf kharf mentioned this pull request Feb 20, 2025
Merged
1 task
This was referenced Feb 20, 2025
Open
Open
@renovate renovate bot mentioned this pull request Feb 20, 2025
Open
1 task
@renovate-rancher renovate-rancher bot mentioned this pull request Feb 20, 2025
Open
1 task
This was referenced Feb 20, 2025
Open
Open
Open
Open
Open
Open
@crossplane-renovate crossplane-renovate bot mentioned this pull request Feb 20, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Feb 20, 2025
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 20, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Feb 20, 2025
Open
1 task
@renovate-bot renovate-bot mentioned this pull request Feb 20, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Feb 20, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @kakkoyun