Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate of #1662 #1673

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Duplicate of #1662 #1673

merged 1 commit into from
Nov 8, 2024

Conversation

imorph
Copy link
Contributor

@imorph imorph commented Nov 4, 2024

This changes were supposed to be merged in #1662 but after some git manipulations it closed itself.
Here clean version of it.

@imorph imorph mentioned this pull request Nov 4, 2024
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

I'll wait a couple of days in case another maintainer wants to take a look before merging

@ArthurSens ArthurSens merged commit 2b11a4b into prometheus:main Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants