Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Shivanth MP <[email protected]>
  • Loading branch information
shivanthzen and ArthurSens authored Oct 18, 2024
1 parent 1eea864 commit d02b6e0
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions prometheus/histogram.go
Original file line number Diff line number Diff line change
Expand Up @@ -1844,9 +1844,7 @@ type constNativeHistogram struct {
nativeHistogramSchema int32
nativeHistogramZeroThreshold float64
nativeHistogramMaxZeroThreshold float64
nativeHistogramMaxBuckets uint32
nativeHistogramMinResetDuration time.Duration
timeStamp time.Time
createdTimestamp time.Time
nativeExemplars []*dto.Exemplar

positiveBuckets map[int]int64
Expand All @@ -1858,9 +1856,9 @@ func NewconstNativeHistogram(desc *Desc, count uint64, sum float64, postiveBucke
labelPairs []*dto.LabelPair, nativeHistogramSchema int32, nativeHistogramZeroThreshold float64,
nativeHistogramMaxZeroThreshold float64, nativeHistogramMaxBuckets uint32,
nativeHistogramMinResetDuration time.Duration,
timeStamp time.Time,
createdTimestamp time.Time,
nativeExemplars []*dto.Exemplar,
) constNativeHistogram {
) (constNativeHistogram, error) {
return constNativeHistogram{

Check failure on line 1862 in prometheus/histogram.go

View workflow job for this annotation

GitHub Actions / lint

not enough return values

Check failure on line 1862 in prometheus/histogram.go

View workflow job for this annotation

GitHub Actions / lint

not enough return values
desc: desc,
count: count,
Expand Down

0 comments on commit d02b6e0

Please sign in to comment.