Skip failing IPv6 tests in test CI Pipeline #1342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests have been failing on the `test` pipeline CI for a while, but they run fine locally on the systems that support ipv4 and ipv6
since we have `test-ipv6` pipeline that runs full test suite in a docker image with IPv6 enabled,
we should be okay to skip these Tests on the `test` pipeline.
The reason these tests are failing is because they are using `net.Listen("tcp", "localhost:0")`,
the use of `tcp` network expects both IPv4 and IPv6.
Signed-off-by: Suraj Nath <[email protected]>
electron0zero
force-pushed
the
fixing_ci_test
branch
from
cddd50f to
2e183c4
Compare
electron0zero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have been failing on the
testpipeline CI for a while, but they run fine locally on the systems that support ipv4 and ipv6Since we have
test-ipv6pipeline that runs full test suite in a docker image with IPv6 enabled,we should be okay to skip these Tests on the
testpipeline.The reason these tests are failing is because they are using
net.Listen("tcp", "localhost:0"),the use of
tcpnetwork expects both IPv4 and IPv6.If we don't want to skip these tests, we can split these tests into a table test with
tcp4andtcp6, and only skiptcp6on thetestpipeline.this was the first approach that came to my mind, and I am open to other approaches as well. if you can think of something better, please suggest other approaches as well.