Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale workflow to start sync with stale.yaml in prometheus #1170

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

electron0zero
Copy link
Member

@electron0zero electron0zero commented Dec 11, 2023

create the .github/workflows/stale.yml for automation to register and keep it sync it in sync with https://github.com/prometheus/prometheus/blob/main/.github/workflows/stale.yml


Add github actions workflow using https://github.com/actions/stale.

It runs everyday and marks issues and pull requests stale with no activity in last 90 days, and it will close stale issues and pull requests without activity for 30 days (120 days before an issue is closed)

issues and pull requests that has label keepalive, dependencies, or bug will be excluded by the workflow.

goal of this workflow is to make it easier for maintainer to maintain the project and close out old issues and PR with automation and save maintainers time :)

ps: when we merge this PR, this workflow will mark issues and pull requests stale that had no activity in last 90 days.

@electron0zero electron0zero requested review from mem and SuperQ December 11, 2023 10:56
@electron0zero electron0zero changed the title Mark pull request and issues as stale after 90d of inactivity Add stale workflow for pull request and issues Dec 11, 2023
@SuperQ
Copy link
Member

SuperQ commented Dec 11, 2023

I wonder if we should have a Prometheus dev discussion about stale bot. I would prefer to keep this setup consistent between projects.

@electron0zero
Copy link
Member Author

electron0zero commented Dec 11, 2023

I wonder if we should have a Prometheus dev discussion about stale bot. I would prefer to keep this setup consistent between projects.

yes, I was looking to see how prometheus does it, and found this PR, which links to Prometheus 2019 Dev Summit 2, which says:

Beorn: General repository health

  • Should be use a bot to mark PRs as stale & close them?
  • CONSENSUS: We should have a bot mark PRs as stale, all repos, 60 days.

but it's using probot app, which is archived now.

Option 1: align this bot's config to match what we have in prometheus/prometheus, but I would prefer to use https://github.com/actions/stale because https://github.com/probot/stale is archived :)

Option 2: I can raise a PR in prometheus/prometheus to use https://github.com/actions/stale, and start a discussion in the mailing list to get consesus on it. once approved, we can use that in our repo, and other exporters.

I am leaning towards option 2.

@SuperQ
Copy link
Member

SuperQ commented Dec 11, 2023

My recommendation

  • Open a PR to convert prometheus/prometheus from probot/stale to actions/stale.
  • Keep the behavior as specified in the old config.
  • Add the stale.yml to scripts/sync_repo_files.sh so that it's copied everywhere.
  • Cleanup the old probot version that's still hanging around in a few places.

There's no need for a new consensus, as we already decided that we should have this everywhere. We just didn't roll it out. 😹

@electron0zero
Copy link
Member Author

opened prometheus/prometheus#14650.

going to close this because once prometheus/prometheus#14650 is merged, config will be synced to our repo.

@electron0zero electron0zero deleted the stale_workflow branch August 9, 2024 17:37
@electron0zero electron0zero restored the stale_workflow branch September 18, 2024 07:09
@electron0zero electron0zero reopened this Sep 18, 2024
@electron0zero
Copy link
Member Author

reopening this PR because we need to create the .github/workflows/stale.yml for automation to register and keep it sync it in sync with https://github.com/prometheus/prometheus/blob/main/.github/workflows/stale.yml

see logs from a recent repo_sync run
image

repo_sync automation in prometheus/prometheus only syncs the
files that exist in the target repo, so create .github/workflows/stale.yml
to register and then automation will keep it in sync with prometheus/prometheus

Signed-off-by: Suraj Nath <[email protected]>
@electron0zero electron0zero changed the title Add stale workflow for pull request and issues Add stale workflow to start sync with stale.yaml in prometheus Sep 18, 2024
@electron0zero electron0zero merged commit 0e4b727 into master Sep 18, 2024
5 checks passed
@electron0zero electron0zero deleted the stale_workflow branch September 18, 2024 09:38
@electron0zero
Copy link
Member Author

ran the repo_sync workflow after merging this and it's correctly showing files in sync.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants